Analytics: Fix update consent method

[kuczmaja]

To send the user's consent status, second arg must be 'default' or 'update'

gtag('consent', 'update', {
    'analytics_storage': 'granted',
    // ....
});

While destructing args in gtagWrapper, the first item is the string, and ConsentSettings is given as the second parameter.

const [gtagParams] = args; // args is [ 'update', { 'analytics_storage': ... } ]
gtagCore(GtagCommand.CONSENT, 'update', gtagParams as ConsentSettings); // gtagParams is 'update' in this case

[changeset-bot]

🦋 Changeset detected

Latest commit: cf3a06b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@firebase/analytics	Patch
@firebase/analytics-compat	Patch
firebase	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[hsubox76]

Thanks for spotting this! One administrative thing you'll need to do: add a changeset, this ensures this change will be published in the next release. Run yarn changeset (see the changeset comment above for more info). Also one comment.

[kuczmaja]

Thanks for the review. The changeset is added.

[Approxipixie]

Thank you for the fix. Could you please provide an update on the status of the PR?
Much appreciated!