Skip to content

Analytics: Fix update consent method #8053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Analytics: Fix update consent method #8053

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1b2ce3a
Analytics: Fix update consent method
kuczmaja Mar 5, 2024
1393c8d
remove comment
kuczmaja Mar 25, 2024
cf3a06b
changeset
kuczmaja Mar 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/analytics/src/helpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,8 @@ function wrapGtag(
gtagParams as GtagConfigOrEventParams
);
} else if (command === GtagCommand.CONSENT) {
const [gtagParams] = args;
// If CONSENT, second arg must be 'default' or 'update'
const [gtagMethod, gtagParams] = args;
gtagCore(GtagCommand.CONSENT, 'update', gtagParams as ConsentSettings);
} else if (command === GtagCommand.GET) {
const [measurementId, fieldName, callback] = args;
Expand Down