-
Notifications
You must be signed in to change notification settings - Fork 977
fix(auth): export MISSING_PASSWORD in AuthErrorCodes #9297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix(auth): export MISSING_PASSWORD in AuthErrorCodes #9297
Conversation
🦋 Changeset detectedLatest commit: a032cd8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
When we make additions to public APIs, we have to update our reference documentation here on this website: https://firebase.google.com/docs/reference. The documentation hosted on that website is generated from the code in our SDK, and stored in the Since you made a public API addition, you need to generate the documentation for this new API. You can do this by running the |
Thanks for the review! |
Thanks for the reminder! |
Summary
Export
MISSING_PASSWORD: 'auth/missing-password'
viaAuthErrorCodes
in @firebase/auth.Why
The SDK can throw
auth/missing-password
, but it wasn’t exposed viaAuthErrorCodes
, forcing developers to hardcode the string.Tests
Adds a Node unit test asserting:
AuthErrorCodes.MISSING_PASSWORD === 'auth/missing-password'
.Fixes
Fixes #9270
CLA
I have signed the Google Contributor License Agreement.