-
Notifications
You must be signed in to change notification settings - Fork 976
fix(auth): export MISSING_PASSWORD in AuthErrorCodes #9297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Navya-arugonda
wants to merge
5
commits into
firebase:main
Choose a base branch
from
Navya-arugonda:fix/auth-missing-password
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+8
−0
Open
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
3156903
fix(auth): export MISSING_PASSWORD in AuthErrorCodes
Navya-arugonda 9289858
chore: add patch changeset for @firebase/auth and firebase
Navya-arugonda 51919b3
fix: reorder MISSING_PASSWORD and remove unnecessary test/config changes
Navya-arugonda bb8d590
docs(auth): update reference for MISSING_PASSWORD export
Navya-arugonda a032cd8
chore(auth): revert jasmine types addition
Navya-arugonda File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
--- | ||
'@firebase/auth': patch | ||
'firebase': patch | ||
--- | ||
|
||
Export MISSING_PASSWORD via AuthErrorCodes in @firebase/auth. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
import { expect } from 'chai'; | ||
import { AuthErrorCodes } from '../../../src'; | ||
|
||
describe('AuthErrorCodes', () => { | ||
it('exports MISSING_PASSWORD', () => { | ||
expect(AuthErrorCodes.MISSING_PASSWORD).to.equal('auth/missing-password'); | ||
}); | ||
}); | ||
Navya-arugonda marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,11 @@ | ||
{ | ||
"extends": "../../config/tsconfig.base.json", | ||
"compilerOptions": { | ||
"outDir": "dist" | ||
"outDir": "dist", | ||
"types": ["mocha", "chai"], | ||
"esModuleInterop": true, | ||
"moduleResolution": "node", | ||
"resolveJsonModule": true | ||
Navya-arugonda marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
}, | ||
"exclude": ["dist/**/*", "demo/**/*"] | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.