Skip to content

Conversation

@kdawgwilk
Copy link
Contributor

@kdawgwilk kdawgwilk commented Nov 21, 2025

  • parse/propagate exclude filters alongside --only, skipping excluded codebases/endpoints
  • apply include/exclude filtering in prepare, deploy planning, and HTTP IAM checks
  • add unit coverage for deployment filters, codebase targeting, and excluded build skipping

Now if you do

firebase deploy --except functions:<codebase_a>

it will not try and load codebase_a. However if you do

firebase deploy --except functions:<codebase_a>:<function_x>

It will still load the codebase in case there are other functions in the codebase

- parse/propagate exclude filters alongside --only, skipping excluded codebases/endpoints
- apply include/exclude filtering in prepare, deploy planning, and HTTP IAM checks
- add unit coverage for deployment filters, codebase targeting, and excluded build skipping
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @kdawgwilk, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly improves the flexibility of functions deployment by implementing support for an --except command-line option. This new feature allows users to precisely control which functions are deployed by specifying exclusions, working in conjunction with the existing --only flag. The changes ensure that functions and codebases marked for exclusion are correctly identified and skipped throughout the entire deployment lifecycle, from initial preparation to final IAM permission checks, and are backed by new unit tests to guarantee reliability.

Highlights

  • Exclude Filter Support: Introduced the ability to specify --except filters for functions, allowing users to explicitly exclude certain functions or codebases from deployment.
  • Integrated Filtering Logic: The new exclusion logic is applied consistently across key deployment phases, including function preparation, deployment planning, and HTTP IAM checks.
  • Enhanced Test Coverage: Added comprehensive unit tests to validate the new deployment filter functionality, codebase targeting, and the skipping of excluded builds.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for the --except flag for function deployments, allowing users to exclude specific functions or codebases. The changes are implemented consistently across the deployment pipeline, including parsing the new flag, filtering codebases in the prepare step, applying filters during IAM checks, and adjusting the deployment planning in the release step. The logic for include/exclude filtering is sound, and the refactoring of existing filter logic to accommodate the new flag is clean. The added unit tests provide good coverage for the new functionality. Overall, this is a solid implementation of the new feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant