feat(vertexai): organize example page and functions#17008
Merged
cynthiajoan merged 3 commits intomainfrom Jan 24, 2025
Merged
Conversation
cynthiajoan
changed the title
Lyokone
approved these changes
Jan 24, 2025
Comment on lines
+161
to
+165
| Map<String, dynamic> location = | ||
| functionCall.args['location']! as Map<String, dynamic>; | ||
| var date = functionCall.args['date']! as String; | ||
| var city = location['city'] as String; | ||
| var state = location['state'] as String; |
Contributor
There was a problem hiding this comment.
I wonder if we could use a proper class with from/toJSON to handle this cleanly
Collaborator
Author
There was a problem hiding this comment.
Like Location { String city, String state}? I feel we could, but would like to defer if we want to make more complicated function calling structure.
packages/firebase_vertexai/firebase_vertexai/example/lib/pages/token_count_page.dart
Outdated
Show resolved
Hide resolved
a-maurice
approved these changes
Jan 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replace this paragraph with a description of what this PR is doing. If you're modifying existing behavior, describe the existing behavior, how this PR is changing it, and what motivated the change.
Related Issues
Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?