fix(crashlytics): Rename test target's host app scheme

[ncooke3]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @ncooke3, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on standardizing the naming conventions within the Crashlytics example project. It renames the host application scheme and its associated test targets across different platforms and build configurations. The primary goal is to simplify and clarify the project's internal references by removing redundant descriptors like 'SwiftUI' and '(iOS)' from the main app name and ensuring consistent naming for the watchOS target.

Highlights

• Host App Scheme Renaming: The remoteInfo property for a PBXContainerItemProxy was updated, changing the host app scheme name from 'CrashlyticsSwiftUIExample (iOS)' to 'CrashlyticsExample'.
• Product Name Update: The productName for the main application target was changed from 'CrashlyticsSwiftUIExample (iOS)' to 'CrashlyticsExample'.
• iOS Test Target Renaming: The TEST_TARGET_NAME in both Debug and Release build configurations for the iOS example was updated from 'CrashlyticsSwiftUIExample (iOS)' to 'CrashlyticsExample'.
• watchOS Test Target Renaming: The TEST_TARGET_NAME in both Debug and Release build configurations for the watchOS example was adjusted from 'CrashlyticsSwiftUIExample_(watchOS)' to 'CrashlyticsExample (watchOS)'.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request aims to rename the test target's host app scheme, but the changes in the project.pbxproj file are incomplete and introduce inconsistencies that will likely break the UI tests for iOS and watchOS. I've pointed out the specific mismatches in TEST_TARGET_NAME and productName that need to be addressed. Manually editing Xcode project files is error-prone, and it seems some related settings were missed during the rename. Please review the comments to ensure the project remains in a buildable state.

[gemini-code-assist]

The TEST_TARGET_NAME build setting must match the PRODUCT_NAME of the host application target. The host target CrashlyticsExample has its PRODUCT_NAME set to CrashlyticsSwiftUIExample (on lines 996 and 1031). Changing TEST_TARGET_NAME to CrashlyticsExample will cause a mismatch and tests will fail to launch. To fix this, TEST_TARGET_NAME should be CrashlyticsSwiftUIExample to match the host's product name.

                                TEST_TARGET_NAME = "CrashlyticsSwiftUIExample";

[gemini-code-assist]

There's a mismatch between the new TEST_TARGET_NAME and the product name of the host target. The host target is CrashlyticsExample_(watchOS), and its PRODUCT_NAME resolves to CrashlyticsExample_(watchOS) (with an underscore). The new value CrashlyticsExample (watchOS) (with a space) will cause a mismatch and tests will fail to launch. Please use an underscore to match the host target's product name.

                                TEST_TARGET_NAME = "CrashlyticsExample_(watchOS)";

[gemini-code-assist]

This change to productName is inconsistent with the PRODUCT_NAME build setting for this target. The build setting is still CrashlyticsSwiftUIExample in the Debug (line 996) and Release (line 1031) configurations. Since the build setting takes precedence, the final product will still be named CrashlyticsSwiftUIExample.app. This makes the change here confusing and ineffective. To complete the rename, you should also update the PRODUCT_NAME build setting.