Skip to content

fix(crashlytics): Rename test target's host app scheme #1788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 22, 2025
Merged

fix(crashlytics): Rename test target's host app scheme #1788

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions crashlytics/CrashlyticsExample.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
containerPortal = 5F5A53441ADE670C00F81DF0 /* Project object */;
proxyType = 1;
remoteGlobalIDString = C73C899D26845908003E5C2C;
remoteInfo = "CrashlyticsSwiftUIExample (iOS)";
remoteInfo = "CrashlyticsExample";
};
C745940626BDDD6200153AE3 /* PBXContainerItemProxy */ = {
isa = PBXContainerItemProxy;
Expand Down Expand Up @@ -374,7 +374,7 @@
packageProductDependencies = (
8D00BB762D3B0AFF00F6F6DD /* FirebaseCrashlytics */,
);
productName = "CrashlyticsSwiftUIExample (iOS)";
productName = "CrashlyticsExample";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This change to productName is inconsistent with the PRODUCT_NAME build setting for this target. The build setting is still CrashlyticsSwiftUIExample in the Debug (line 996) and Release (line 1031) configurations. Since the build setting takes precedence, the final product will still be named CrashlyticsSwiftUIExample.app. This makes the change here confusing and ineffective. To complete the rename, you should also update the PRODUCT_NAME build setting.

productReference = C73C899E26845908003E5C2C /* CrashlyticsSwiftUIExample.app */;
productType = "com.apple.product-type.application";
};
Expand Down Expand Up @@ -933,7 +933,7 @@
SWIFT_OPTIMIZATION_LEVEL = "-Onone";
SWIFT_VERSION = 5.0;
TARGETED_DEVICE_FAMILY = "1,2";
TEST_TARGET_NAME = "CrashlyticsSwiftUIExample (iOS)";
TEST_TARGET_NAME = "CrashlyticsExample";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The TEST_TARGET_NAME build setting must match the PRODUCT_NAME of the host application target. The host target CrashlyticsExample has its PRODUCT_NAME set to CrashlyticsSwiftUIExample (on lines 996 and 1031). Changing TEST_TARGET_NAME to CrashlyticsExample will cause a mismatch and tests will fail to launch. To fix this, TEST_TARGET_NAME should be CrashlyticsSwiftUIExample to match the host's product name.

                                TEST_TARGET_NAME = "CrashlyticsSwiftUIExample";

};
name = Debug;
};
Expand Down Expand Up @@ -963,7 +963,7 @@
PRODUCT_NAME = "$(TARGET_NAME)";
SWIFT_VERSION = 5.0;
TARGETED_DEVICE_FAMILY = "1,2";
TEST_TARGET_NAME = "CrashlyticsSwiftUIExample (iOS)";
TEST_TARGET_NAME = "CrashlyticsExample";
};
name = Release;
};
Expand Down Expand Up @@ -1356,7 +1356,7 @@
SWIFT_OPTIMIZATION_LEVEL = "-Onone";
SWIFT_VERSION = 5.0;
TARGETED_DEVICE_FAMILY = 4;
TEST_TARGET_NAME = "CrashlyticsSwiftUIExample_(watchOS)";
TEST_TARGET_NAME = "CrashlyticsExample (watchOS)";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

There's a mismatch between the new TEST_TARGET_NAME and the product name of the host target. The host target is CrashlyticsExample_(watchOS), and its PRODUCT_NAME resolves to CrashlyticsExample_(watchOS) (with an underscore). The new value CrashlyticsExample (watchOS) (with a space) will cause a mismatch and tests will fail to launch. Please use an underscore to match the host target's product name.

                                TEST_TARGET_NAME = "CrashlyticsExample_(watchOS)";

WATCHOS_DEPLOYMENT_TARGET = 7.4;
};
name = Debug;
Expand Down Expand Up @@ -1391,7 +1391,7 @@
SWIFT_EMIT_LOC_STRINGS = NO;
SWIFT_VERSION = 5.0;
TARGETED_DEVICE_FAMILY = 4;
TEST_TARGET_NAME = "CrashlyticsSwiftUIExample_(watchOS)";
TEST_TARGET_NAME = "CrashlyticsExample (watchOS)";
WATCHOS_DEPLOYMENT_TARGET = 7.4;
};
name = Release;
Expand Down