chore: remove too fast benches #4810
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShadowCurse
added
Status: Awaiting review
ShadowCurse
force-pushed
the
remove_too_fast_benches
branch
from
9289505 to
8c972ef
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4810 +/- ##
=======================================
Coverage 84.32% 84.32%
=======================================
Files 249 249
Lines 27512 27512
=======================================
Hits 23200 23200
Misses 4312 4312
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Some benchmarks are very small and fast and this causes them to be unstable. We can still keep an eye on the performance with longer benches. Also increased number of runs and threshold. This should be fine as all tests still run in nanoseconds. Signed-off-by: Egor Lazarchuk <[email protected]>
ShadowCurse
force-pushed
the
remove_too_fast_benches
branch
from
8c972ef to
0f04f16
Compare
pb8o
approved these changes
Sep 17, 2024
pb8o
approved these changes
Sep 17, 2024
JackThomson2
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Some benchmarks are very small and fast and this causes them to be unstable. We still keep an eye on the performance with longer benches.
Reason
Lower down variability in bench results.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
PR.
CHANGELOG.md.TODOs link to an issue.contribution quality standards.
rust-vmm.