Skip to content

chore: remove too fast benches #4810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 18, 2024
Merged

chore: remove too fast benches #4810

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0f04f16
chore: update too fast benches
ShadowCurse Sep 17, 2024
56b8824
Merge branch 'main' into remove_too_fast_benches
pb8o Sep 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/vmm/benches/block_request.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ use vmm::devices::virtio::test_utils::VirtQueue;
use vmm::test_utils::single_region_mem;

pub fn block_request_benchmark(c: &mut Criterion) {
let mem = single_region_mem(2 * 65562);
let mem = single_region_mem(65562);
let virt_queue = VirtQueue::new(GuestAddress(0), &mem, 16);

// We don't really care about what request is. We just
Expand All @@ -36,7 +36,7 @@ pub fn block_request_benchmark(c: &mut Criterion) {

criterion_group! {
name = block_request_benches;
config = Criterion::default().sample_size(200).noise_threshold(0.05);
config = Criterion::default().sample_size(1000).noise_threshold(0.05);
targets = block_request_benchmark
}

Expand Down
72 changes: 1 addition & 71 deletions src/vmm/benches/queue.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,42 +59,6 @@ pub fn queue_benchmark(c: &mut Criterion) {
let rxq = VirtQueue::new(GuestAddress(0), &mem, 256);
let mut queue = rxq.create_queue();

set_dtable_one_chain(&rxq, 1);
queue.next_avail = Wrapping(0);
let desc = queue.pop().unwrap();
c.bench_function("next_descriptor_1", |b| {
b.iter(|| {
let mut head = Some(desc);
while let Some(d) = head {
head = std::hint::black_box(d.next_descriptor());
}
})
});

set_dtable_one_chain(&rxq, 2);
queue.next_avail = Wrapping(0);
let desc = queue.pop().unwrap();
c.bench_function("next_descriptor_2", |b| {
b.iter(|| {
let mut head = Some(desc);
while let Some(d) = head {
head = std::hint::black_box(d.next_descriptor());
}
})
});

set_dtable_one_chain(&rxq, 4);
queue.next_avail = Wrapping(0);
let desc = queue.pop().unwrap();
c.bench_function("next_descriptor_4", |b| {
b.iter(|| {
let mut head = Some(desc);
while let Some(d) = head {
head = std::hint::black_box(d.next_descriptor());
}
})
});

set_dtable_one_chain(&rxq, 16);
queue.next_avail = Wrapping(0);
let desc = queue.pop().unwrap();
Expand All @@ -107,28 +71,6 @@ pub fn queue_benchmark(c: &mut Criterion) {
})
});

// Queue pop

set_dtable_many_chains(&rxq, 1);
c.bench_function("queue_pop_1", |b| {
b.iter(|| {
queue.next_avail = Wrapping(0);
while let Some(desc) = queue.pop() {
std::hint::black_box(desc);
}
})
});

set_dtable_many_chains(&rxq, 4);
c.bench_function("queue_pop_4", |b| {
b.iter(|| {
queue.next_avail = Wrapping(0);
while let Some(desc) = queue.pop() {
std::hint::black_box(desc);
}
})
});

set_dtable_many_chains(&rxq, 16);
c.bench_function("queue_pop_16", |b| {
b.iter(|| {
Expand All @@ -139,18 +81,6 @@ pub fn queue_benchmark(c: &mut Criterion) {
})
});

c.bench_function("queue_add_used_1", |b| {
b.iter(|| {
queue.num_added = Wrapping(0);
queue.next_used = Wrapping(0);
for i in 0_u16..1_u16 {
let index = std::hint::black_box(i);
let len = std::hint::black_box(i + 1);
_ = queue.add_used(index as u16, len as u32);
}
})
});

c.bench_function("queue_add_used_16", |b| {
b.iter(|| {
queue.num_added = Wrapping(0);
Expand Down Expand Up @@ -178,7 +108,7 @@ pub fn queue_benchmark(c: &mut Criterion) {

criterion_group! {
name = queue_benches;
config = Criterion::default().sample_size(200).noise_threshold(0.05);
config = Criterion::default().sample_size(1000).noise_threshold(0.15);
targets = queue_benchmark
}

Expand Down
Loading