fix: ensure ci artifacts are present when using devtool sandbox #4931
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without ensure_ci_artifacts called inside cmd_sandbox, you will see an index out of bounds errors during set up of the argument parser, since build/img will be an empty directory (e.g. there are no kernels to select, and the -1 index will be out of bounds). Reported-by: Jack Thomson <[email protected]> Signed-off-by: Patrick Roy <[email protected]>
roypat
added
the
Status: Awaiting review
pb8o
approved these changes
Nov 27, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4931 +/- ##
=======================================
Coverage 84.08% 84.08%
=======================================
Files 251 251
Lines 28058 28058
=======================================
Hits 23592 23592
Misses 4466 4466
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
JackThomson2
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without ensure_ci_artifacts called inside cmd_sandbox, you will see an index out of bounds errors during set up of the argument parser, since build/img will be an empty directory (e.g. there are no kernels to select, and the -1 index will be out of bounds).
Reported-by: Jack Thomson [email protected]
Changes
...
Reason
...
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.