Revert "fix: test_sec_audit: ignore cargo audit output" #5078
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d761b01. The output to stdout was fixed in cargo audit 0.21.2, so if we rebuild the docker container the grep is no longer necessary. In fact, the grep has broken this test in our nightly pipeline because it overwrites the return code of cargo audit itself, meaning the non-PR version of this test (which is supposed to fail if there exist any cargo audit warnings) was never failing. Signed-off-by: Patrick Roy <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5078 +/- ##
=======================================
Coverage 83.15% 83.15%
=======================================
Files 248 248
Lines 26901 26901
=======================================
Hits 22370 22370
Misses 4531 4531
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
roypat
added
the
Status: Awaiting review
zulinx86
previously approved these changes
Mar 12, 2025
zulinx86
reviewed
Mar 12, 2025
I left a comment about unpinning cargo deny to our rust toolchain upgrade tracker! |
The newest 0.18.0 release requires at least rust 1.85.0 to compile. Needs to be unpinned later after toolchain upgrade. Signed-off-by: Patrick Roy <[email protected]>
v78 contains updated cargo-audit Signed-off-by: Patrick Roy <[email protected]>
ShadowCurse
approved these changes
Mar 12, 2025
zulinx86
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit d761b01. The output to stdout was fixed in cargo audit 0.21.2, so if we rebuild the docker container (needed to pick up the new cargo audit version, as currently we're on 0.21.0) the grep is no longer necessary.
In fact, the grep has broken this test in our nightly pipeline because it overwrites the return code of cargo audit itself, meaning the non-PR version of this test (which is supposed to fail if there exist any cargo audit warnings) was never failing.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.