Fix two annoyances with compiling Firecracker through devtool/test #5157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
way too often have I accidentally ran an out dated firecracker binary when testing something because a change I made doesnt compile, but the failure to build firecracker wasn't considered fatal by devtool, and the sheer amount of stuff it prints after compiling pushed the compiler error offscreen. Fix this by exiting if firecracker fails to build. Signed-off-by: Patrick Roy <[email protected]>
When running A/B tests, this part of the documentation explicitly builds firecracker from two revisions. However, after that it will _still_ build Firecracker from HEAD _again_, even though this third compilation of firecracker is not needed: The A/B test will only ever use the precompiled binaries. Fix this by passing --no-build in the example Signed-off-by: Patrick Roy <[email protected]>
roypat
requested review from
Manciukic,
kalyazin,
pb8o and
xmarcalx
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5157 +/- ##
==========================================
+ Coverage 83.04% 83.09% +0.05%
==========================================
Files 250 250
Lines 26892 26892
==========================================
+ Hits 22332 22346 +14
+ Misses 4560 4546 -14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
roypat
added
the
Status: Awaiting review
ShadowCurse
approved these changes
Apr 15, 2025
kalyazin
approved these changes
Apr 15, 2025
zulinx86
approved these changes
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
devtool testLicense Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.