Skip to content

Fix two annoyances with compiling Firecracker through devtool/test #5157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 15, 2025
Merged

Fix two annoyances with compiling Firecracker through devtool/test #5157

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
29ed105
fix(devtool): exit with error if firecracker fails to build
roypat Apr 15, 2025
2f8b990
doc(test): suggest --no-build in conjunction with --ab
roypat Apr 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ branch and the `HEAD` of your current branch, run
```sh
tools/devtool -y build --rev main --release
tools/devtool -y build --rev HEAD --release
tools/devtool -y test --ab -- run build/main build/HEAD --test integration_tests/performance/test_boottime.py::test_boottime
tools/devtool -y test --no-build --ab -- run build/main build/HEAD --test integration_tests/performance/test_boottime.py::test_boottime
```

#### How to Write an A/B-Compatible Test and Common Pitfalls
Expand Down
1 change: 1 addition & 0 deletions tools/devtool
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -723,6 +723,7 @@ cmd_test() {
cmd_build --release
if [ -n "$BUILDKITE_PULL_REQUEST_BASE_BRANCH" ]; then
cmd_build --release --rev "$BUILDKITE_PULL_REQUEST_BASE_BRANCH"
ok_or_die "Failed to build Firecracker!"
fi
fi

Expand Down