Split post-snapshot checks for steal time test #5210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bchalios
force-pushed
the
fix_steal_time_test
branch
from
cb4349d to
11cca87
Compare
bchalios
added
the
Status: Awaiting review
zulinx86
previously approved these changes
May 15, 2025
test_pvtime_snapshot checks that steal time reporting mechanism works on snapshotted microVMs. This includes two checks; first that the old steal time values are saved and restored correctly through snapshots and second that steal time keeps increasing in microVMs resumed from a snapshot. The test fails intermittently, but we are not sure which of the two invariants causes it to fail because we are checking both in the same assertion. Split this assertion in two so that we understand better the culprit. Signed-off-by: Babis Chalios <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5210 +/- ##
==========================================
+ Coverage 82.88% 82.93% +0.05%
==========================================
Files 250 250
Lines 26936 26936
==========================================
+ Hits 22325 22339 +14
+ Misses 4611 4597 -14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bchalios
force-pushed
the
fix_steal_time_test
branch
from
11cca87 to
516e950
Compare
zulinx86
approved these changes
May 15, 2025
ShadowCurse
approved these changes
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Split the double assertion in
test_pvtime_snapshotin two separate ones.Reason
test_pvtime_snapshotchecks that steal time reporting mechanism works on snapshotted microVMs. This includes two checks; first that the old steal time values are saved and restored correctly through snapshots and second that steal time keeps increasing in microVMs resumed from a snapshot.The test fails intermittently, but we are not sure which of the two invariants causes it to fail because we are checking both in the same assertion
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.