Skip to content

Split post-snapshot checks for steal time test #5210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 15, 2025
Merged

Split post-snapshot checks for steal time test #5210

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
516e950
fix(test): split post-snapshot checks for steal time test
bchalios May 15, 2025
5d3d2d8
Merge branch 'main' into fix_steal_time_test
bchalios May 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 10 additions & 9 deletions tests/integration_tests/functional/test_steal_time.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,18 +104,19 @@ def test_pvtime_snapshot(uvm_plain, microvm_factory):
# Steal time just after restoring
steal_after_snap = get_steal_time_ms(restored_vm)

time.sleep(2)

# Steal time after running resumed VM
steal_after_resume = get_steal_time_ms(restored_vm)

# Ensure steal time persisted and continued increasing
# Ensure steal time persisted
tolerance = 10000 # 10.0 seconds tolerance for persistence check
persisted = (
steal_before < steal_after_snap and steal_after_snap - steal_before < tolerance
)
increased = steal_after_resume > steal_after_snap
assert persisted, "Steal time did not persist through snapshot"

time.sleep(2)

# Steal time after running resumed VM
steal_after_resume = get_steal_time_ms(restored_vm)

# Ensure steal time continued increasing
assert (
persisted and increased
), "Steal time did not persist through snapshot or failed to increase after resume"
steal_after_resume > steal_after_snap
), "Steal time failed to increase after resume"