Skip to content

chore(test/msr): update Sapphire Rapids baseline with NO_ITS bit #5267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 18, 2025
Merged

chore(test/msr): update Sapphire Rapids baseline with NO_ITS bit #5267

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f9ce0ca
chore(test/msr): update SPR and SKL fingerprints with ITS_NO bit
Manciukic Jun 17, 2025
220cdb0
chore(test/msr): update G4 fingerprint for SMCCC_ARCH_WORKAROUND_3
Manciukic Jun 17, 2025
1e2c233
chore(cpu_templates): use explicit wait in pipeline definition
Manciukic Jun 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 14 additions & 10 deletions .buildkite/pipeline_cpu_template.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,16 +88,18 @@ def group_snapshot_restore(test_step):
groups = []

groups.append(
group(
label=test_step["snapshot"][BkStep.LABEL],
command=test_step["snapshot"][BkStep.COMMAND],
instances=test_step["instances"],
platforms=DEFAULT_PLATFORMS,
timeout=test_step["snapshot"][BkStep.TIMEOUT],
artifacts=test_step["snapshot"][BkStep.ARTIFACTS],
)
{
"key": "snapshot",
**group(
label=test_step["snapshot"][BkStep.LABEL],
command=test_step["snapshot"][BkStep.COMMAND],
instances=test_step["instances"],
platforms=DEFAULT_PLATFORMS,
timeout=test_step["snapshot"][BkStep.TIMEOUT],
artifacts=test_step["snapshot"][BkStep.ARTIFACTS],
),
}
)
groups.append("wait")
snapshot_restore_combinations = []
for dp in DEFAULT_PLATFORMS:
for src_instance in test_step["instances"]:
Expand Down Expand Up @@ -137,7 +139,9 @@ def group_snapshot_restore(test_step):
}
)

groups.append({"group": "📸 restores snapshots", "steps": steps})
groups.append(
{"group": "📸 restores snapshots", "steps": steps, "depends_on": "snapshot"}
)
return groups


Expand Down
6 changes: 3 additions & 3 deletions tests/data/cpu_template_helper/fingerprint_ARM_NEOVERSE_V2_6.1host.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"firecracker_version": "1.12.0-dev",
"kernel_version": "6.1.129-138.220.amzn2023.aarch64",
"firecracker_version": "1.13.0-dev",
"kernel_version": "6.1.140-154.222.amzn2023.aarch64",
"microcode_version": "0x0000000000000017",
"bios_version": "1.0",
"bios_revision": "1.0",
Expand Down Expand Up @@ -834,7 +834,7 @@
},
{
"addr": "0x6030000000140003",
"bitmap": "0b00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000010"
"bitmap": "0b00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000001"
},
{
"addr": "0x6030000000160000",
Expand Down
10 changes: 5 additions & 5 deletions tests/data/cpu_template_helper/fingerprint_INTEL_SAPPHIRE_RAPIDS_6.1host.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
{
"firecracker_version": "1.12.0-dev",
"kernel_version": "6.1.129-138.220.amzn2023.x86_64",
"microcode_version": "0x2b000620",
"firecracker_version": "1.13.0-dev",
"kernel_version": "6.1.140-154.222.amzn2023.x86_64",
"microcode_version": "0x2b000639",
"bios_version": "1.0",
"bios_revision": "3.3",
"bios_revision": "3.10",
"guest_cpu_config": {
"kvm_capabilities": [],
"cpuid_modifiers": [
Expand Down Expand Up @@ -1431,7 +1431,7 @@
},
{
"addr": "0x10a",
"bitmap": "0b0000000000000000000000000000000000001100000010001110000011101011"
"bitmap": "0b0100000000000000000000000000000000001100000010001110000011101011"
},
{
"addr": "0x140",
Expand Down
8 changes: 4 additions & 4 deletions tests/data/cpu_template_helper/fingerprint_INTEL_SKYLAKE_6.1host.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
{
"firecracker_version": "1.12.0-dev",
"kernel_version": "6.1.129-138.220.amzn2023.x86_64",
"firecracker_version": "1.13.0-dev",
"kernel_version": "6.1.140-154.222.amzn2023.x86_64",
"microcode_version": "0x2007006",
"bios_version": "1.0",
"bios_revision": "4.11",
"bios_revision": "4.13",
"guest_cpu_config": {
"kvm_capabilities": [],
"cpuid_modifiers": [
Expand Down Expand Up @@ -1128,7 +1128,7 @@
},
{
"addr": "0x10a",
"bitmap": "0b0000000000000000000000000000000000001100000000000000000001001100"
"bitmap": "0b0100000000000000000000000000000000001100000000000000000001001100"
},
{
"addr": "0x140",
Expand Down
8 changes: 4 additions & 4 deletions tests/data/msr/msr_list_SPR_TO_T2_6.1_INTEL_SAPPHIRE_RAPIDS_6.1host_5.10guest.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
MSR_ADDR,VALUE
0x0,0x0
0x1,0x0
0x10,0xbae96682
0x10,0x7c90dcf2
0x11,0x24a1008
0x12,0x24a2001
0x17,0x0
Expand All @@ -18,7 +18,7 @@ MSR_ADDR,VALUE
0xcd,0x3
0xce,0x80000000
0xfe,0x508
0x10a,0xc08e0eb
0x10a,0x400000000c08e0eb
0x11e,0xbe702111
0x122,0x3
0x140,0x0
Expand Down Expand Up @@ -200,7 +200,7 @@ MSR_ADDR,VALUE
0x619,0x0
0x639,0x0
0x641,0x0
0x6e0,0x18e92c0b0
0x6e0,0x7d409184
0x800,0x0
0x801,0x0
0x802,0x0
Expand Down Expand Up @@ -462,7 +462,7 @@ MSR_ADDR,VALUE
0xc0000082,0xffffffff81a00080
0xc0000083,0xffffffff81a015c0
0xc0000084,0x47700
0xc0000100,0x7f1687b37740
0xc0000100,0x3d11f380
0xc0000101,0xffff88803ec00000
0xc0000102,0x0
0xc0000103,0x0
Expand Down
8 changes: 4 additions & 4 deletions tests/data/msr/msr_list_SPR_TO_T2_6.1_INTEL_SAPPHIRE_RAPIDS_6.1host_6.1guest.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
MSR_ADDR,VALUE
0x0,0x0
0x1,0x0
0x10,0x7b423550
0x10,0x6f38b066
0x11,0x25cb008
0x12,0x25cc001
0x17,0x0
Expand All @@ -18,7 +18,7 @@ MSR_ADDR,VALUE
0xcd,0x3
0xce,0x80000000
0xfe,0x508
0x10a,0xc08e0eb
0x10a,0x400000000c08e0eb
0x11e,0xbe702111
0x122,0x3
0x140,0x0
Expand Down Expand Up @@ -200,7 +200,7 @@ MSR_ADDR,VALUE
0x619,0x0
0x639,0x0
0x641,0x0
0x6e0,0x162fb7dfe
0x6e0,0x6f8e7c12
0x800,0x0
0x801,0x0
0x802,0x0
Expand Down Expand Up @@ -462,7 +462,7 @@ MSR_ADDR,VALUE
0xc0000082,0xffffffff81a00080
0xc0000083,0x0
0xc0000084,0x257fd5
0xc0000100,0x7fbb7b0e1740
0xc0000100,0x14cb9380
0xc0000101,0xffff88803ec00000
0xc0000102,0x0
0xc0000103,0x0
Expand Down