-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Update feature/secret-hiding with more recent iterations of patch series #5293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
roypat
merged 6 commits into
firecracker-microvm:feature/secret-hiding
from
roypat:updated-patch-series
Jul 14, 2025
Merged
Update feature/secret-hiding with more recent iterations of patch series #5293
roypat
merged 6 commits into
firecracker-microvm:feature/secret-hiding
from
roypat:updated-patch-series
Jul 14, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/secret-hiding #5293 +/- ##
=========================================================
- Coverage 81.81% 81.81% -0.01%
=========================================================
Files 250 250
Lines 27666 27635 -31
=========================================================
- Hits 22635 22609 -26
+ Misses 5031 5026 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
6441b62 to
a33921e
Compare
kalyazin
reviewed
Jul 8, 2025
b6a218f to
1e6c8eb
Compare
10 tasks
ff1c5d5 to
22ceb08
Compare
- Drop setting memory attributes to private (workaround was needed to get KVM to fault non-coco VMs through guest_memfd always) - Drop no-kvmclock (we have a workaround patch now) - Drop VM types (guest_memfd is now supported on all vm types). - Update kvm capability numbers Signed-off-by: Patrick Roy <[email protected]>
CONFIG_KVM_PRIVATE_MEM is dead, and CONFIG_KVM_GMEM which replaces it is automatically selected. Signed-off-by: Patrick Roy <[email protected]>
170ce9d to
11970a6
Compare
With the updated host kernel, the bug that made them fail seems to have been fixed. Signed-off-by: Patrick Roy <[email protected]>
Writing to the noturbo sysfs immediately locks up the entire instance, so stop doing this for now. Signed-off-by: Patrick Roy <[email protected]>
11970a6 to
8dd1215
Compare
It's currently broken on the host kernel we're using. Signed-off-by: Patrick Roy <[email protected]>
79d3271 to
0b268ce
Compare
0b268ce to
cd04eff
Compare
Linus fixed an issue introduced between -rc4 and -rc5 that shows up as random userspace processes hanging without and kernel logs to show what might be going from [1]. This pretty much exactly matches what we are seeing with docekr just random hanging sometimes. Let's try updating to -rc6 to see if that makes the issue go away. On aarch64, this kernel needs some additional dependencies to build (hexdump), which we do not have in the docker container, so add a "instlal build dependencies" step to the kernel building script. [1]: https://lore.kernel.org/all/CAHk-=wiMJWwgJ4HYsLzJ4_OkhzJ75ah0HrfBBk+W-RGjk4-h2g@mail.gmail.com/ Signed-off-by: Patrick Roy <[email protected]>
cd04eff to
d006372
Compare
JackThomson2
approved these changes
Jul 14, 2025
zulinx86
approved these changes
Jul 14, 2025
48890ef
into
firecracker-microvm:feature/secret-hiding
5 of 7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade the base "mmap support for guest_memfd" series from Fuad's v4 to v12, and do all the Firecracker changes that come with it.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.