test(network_latency): drop check on number of pings returned #5317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test_network_latency uses ping to send 15 rounds of 30 pings from the guest to the host and collects the latencies printed. For this, instead of just parsing the ping output for however many lines of latency data there we, implicitly assert that we get exactly 30. However, sometimes this fails. Nikita and Egor investigated and found that no packages are lost, sometimes ping just seems to not print all 30 lines for some reason (presumably a bug in ping). So just drop this assertion to stop spurious test failures from happening. This is a performance test, not a functional test anyway. Signed-off-by: Patrick Roy <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5317 +/- ##
==========================================
+ Coverage 82.96% 83.02% +0.05%
==========================================
Files 250 250
Lines 26828 26828
==========================================
+ Hits 22259 22273 +14
+ Misses 4569 4555 -14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
roypat
added
the
Status: Awaiting review
kalyazin
approved these changes
Jul 21, 2025
Manciukic
approved these changes
Jul 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_network_latency uses ping to send 15 rounds of 30 pings from the guest to the host and collects the latencies printed. For this, instead of just parsing the ping output for however many lines of latency data there we, implicitly assert that we get exactly 30. However, sometimes this fails. Nikita and Egor investigated and found that no packages are lost, sometimes ping just seems to not print all 30 lines for some reason (presumably a bug in ping). So just drop this assertion to stop spurious test failures from happening. This is a performance test, not a functional test anyway.
Changes
...
Reason
...
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkbuild --allto verify that the PR passesbuild checks on all supported architectures.
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.