Skip to content

test(network_latency): drop check on number of pings returned #5317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 21, 2025
+6 −6
Merged

test(network_latency): drop check on number of pings returned #5317

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions tests/integration_tests/performance/test_network.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
from framework.utils_iperf import IPerf3Test, emit_iperf3_metrics


def consume_ping_output(ping_putput, request_per_round):
def consume_ping_output(ping_putput):
"""Consume ping output.

Output example:
Expand All @@ -29,12 +29,12 @@ def consume_ping_output(ping_putput, request_per_round):
assert len(output) > 2

# Compute percentiles.
seqs = output[1 : request_per_round + 1]
pattern_time = ".+ bytes from .+: icmp_seq=.+ ttl=.+ time=(.+) ms"
for seq in seqs:
for seq in output:
time = re.findall(pattern_time, seq)
assert len(time) == 1
yield float(time[0])
if time:
assert len(time) == 1
yield float(time[0])


@pytest.fixture
Expand Down Expand Up @@ -81,7 +81,7 @@ def test_network_latency(network_microvm, metrics):
f"ping -c {request_per_round} -i {delay} {host_ip}"
)

samples.extend(consume_ping_output(ping_output, request_per_round))
samples.extend(consume_ping_output(ping_output))

for sample in samples:
metrics.put_metric("ping_latency", sample, "Milliseconds")
Expand Down