Add some tolerance in test_serial_dos #5333
Merged
+6
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test_serial_dos ensures that the internal FIFO buffer used for storing the bytes to be written does not grow indefinitely. Some times during the test we observe small allocations that make the assertion fail. Add some tolerance to the test (1%) to avoid false positives. Signed-off-by: Babis Chalios <[email protected]>
bchalios
added
the
Status: Awaiting review
Manciukic
approved these changes
Jul 29, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5333 +/- ##
==========================================
+ Coverage 82.98% 83.03% +0.05%
==========================================
Files 250 250
Lines 26837 26837
==========================================
+ Hits 22271 22285 +14
+ Misses 4566 4552 -14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Manciukic
reviewed
Jul 29, 2025
roypat
approved these changes
Jul 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add some tolerance (1%) to the memory size check of
test_serial_io.py::test_serial_dosto avoid false positives.Reason
test_serial_dosensures that the internal FIFO buffer used for storing the bytes to be written does not grow indefinitely. Some times during the test we observe small allocations that make the assertion fail.License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkbuild --allto verify that the PR passesbuild checks on all supported architectures.
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.