Skip to content

Add some tolerance in test_serial_dos #5333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2025
Merged

Add some tolerance in test_serial_dos #5333

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions tests/integration_tests/functional/test_serial_io.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,9 @@ def get_total_mem_size(pid):
_, stdout, stderr = utils.check_output(cmd)
assert stderr == ""

return stdout
# This assumes that the pmap returns something in the form of
# 123456789K (which is typically the case for us)
return float(stdout.strip()[:-1] * 1000)


def send_bytes(tty, bytes_count, timeout=60):
Expand Down Expand Up @@ -156,7 +158,9 @@ def test_serial_dos(uvm_plain_any):
before_size = get_total_mem_size(microvm.firecracker_pid)
send_bytes(tty_fd, 100000000, timeout=1)
after_size = get_total_mem_size(microvm.firecracker_pid)
assert before_size == after_size, (
# Give the check a bit of tolerance (1%) since sometimes random unrelated
# allocations break it.
assert after_size <= (before_size * 1.01), (
"The memory size of the "
"Firecracker process "
"changed from {} to {}.".format(before_size, after_size)
Expand Down