Skip to content

chore: remove sleep from wrmsr test #5361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 13, 2025
Merged

chore: remove sleep from wrmsr test #5361

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1b1b125
chore: remove sleep from wrmsr test
Manciukic Aug 11, 2025
1b40677
Merge branch 'main' into issues/3453
Manciukic Aug 12, 2025
3482bbf
Merge branch 'main' into issues/3453
Manciukic Aug 13, 2025
79931ad
Merge branch 'main' into issues/3453
Manciukic Aug 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions tests/integration_tests/functional/test_cpu_features_x86_64.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
import re
import shutil
import sys
import time
from difflib import unified_diff
from pathlib import Path

Expand Down Expand Up @@ -421,11 +420,6 @@ def test_cpu_wrmsr_snapshot(
msrs_before_fname = snapshot_artifacts_dir / shared_names["msrs_before_fname"]

dump_msr_state_to_file(msr_reader_bin, msrs_before_fname, vm.ssh)
# On T2A, the restore test fails with error "cannot allocate memory" so,
# adding delay below as a workaround to unblock the tests for now.
# TODO: Debug the issue and remove this delay. Create below issue to track this:
# https://github.com/firecracker-microvm/firecracker/issues/3453
time.sleep(0.25)

# Take a snapshot
snapshot = vm.snapshot_diff()
Expand Down