Skip to content

Conversation

roypat
Copy link
Contributor

@roypat roypat commented Sep 12, 2025

Continuation of the work started in #5182. My main contribution is just code cleanup, and transforming the standalone test into a pytest integration test in the style group.

The output of the test when failing looks like this:

📄 Defined in: ../src/vmm/src/devices/virtio/net/metrics.rs
Possibly Unused: 

   ❌ rx_partial_writes (SharedIncMetric)
   ❌ tx_partial_reads (SharedIncMetric)

📄 Defined in: ../src/vmm/src/logger/metrics.rs
Possibly Unused: 

   ❌ sync_response_fails (SharedIncMetric)
   ❌ sync_vmm_send_timeout_count (SharedIncMetric)
   ❌ deprecated_cmd_line_api_calls (SharedIncMetric)
   ❌ log_fails (SharedIncMetric)
   ❌ device_events (SharedIncMetric)

which can be easily tested by reverting the first commit in this PR, and running the test.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • I have read and understand CONTRIBUTING.md.
  • I have run tools/devtool checkbuild --all to verify that the PR passes
    build checks on all supported architectures.
  • I have run tools/devtool checkstyle to verify that the PR passes the
    automated style checks.
  • I have described what is done in these changes, why they are needed, and
    how they are solving the problem in a clear and encompassing way.
  • I have updated any relevant documentation (both in code and in the docs)
    in the PR.
  • I have mentioned all user-facing changes in CHANGELOG.md.
  • If a specific issue led to this PR, this PR closes the issue.
  • When making API changes, I have followed the
    Runbook for Firecracker API changes.
  • I have tested all new and changed functionalities in unit tests and/or
    integration tests.
  • I have linked an issue to every new TODO.

  • This functionality cannot be added in rust-vmm.

Copy link

codecov bot commented Sep 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.78%. Comparing base (c3fbe05) to head (d3648ab).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5439      +/-   ##
==========================================
- Coverage   82.79%   82.78%   -0.01%     
==========================================
  Files         263      263              
  Lines       27301    27292       -9     
==========================================
- Hits        22603    22594       -9     
  Misses       4698     4698              
Flag Coverage Δ
5.10-m5n.metal 82.97% <ø> (-0.01%) ⬇️
5.10-m6a.metal 82.22% <ø> (-0.01%) ⬇️
5.10-m6g.metal 79.56% <ø> (-0.02%) ⬇️
5.10-m6i.metal 82.96% <ø> (-0.01%) ⬇️
5.10-m7a.metal-48xl 82.21% <ø> (-0.01%) ⬇️
5.10-m7g.metal 79.57% <ø> (-0.01%) ⬇️
5.10-m7i.metal-24xl 82.93% <ø> (-0.02%) ⬇️
5.10-m7i.metal-48xl 82.93% <ø> (-0.01%) ⬇️
5.10-m8g.metal-24xl 79.56% <ø> (-0.01%) ⬇️
5.10-m8g.metal-48xl 79.56% <ø> (-0.02%) ⬇️
6.1-m5n.metal 83.00% <ø> (-0.01%) ⬇️
6.1-m6a.metal 82.26% <ø> (-0.01%) ⬇️
6.1-m6g.metal 79.56% <ø> (-0.01%) ⬇️
6.1-m6i.metal 83.00% <ø> (-0.02%) ⬇️
6.1-m7a.metal-48xl 82.25% <ø> (-0.01%) ⬇️
6.1-m7g.metal 79.56% <ø> (-0.01%) ⬇️
6.1-m7i.metal-24xl 83.01% <ø> (-0.01%) ⬇️
6.1-m7i.metal-48xl 83.01% <ø> (-0.01%) ⬇️
6.1-m8g.metal-24xl 79.56% <ø> (-0.02%) ⬇️
6.1-m8g.metal-48xl 79.56% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@roypat roypat added the Status: Awaiting review Indicates that a pull request is ready to be reviewed label Sep 12, 2025
roypat and others added 2 commits September 17, 2025 15:10
Remove metrics that were never incremented.

Closes firecracker-microvm#2901

Signed-off-by: Patrick Roy <[email protected]>
Add a test that fails if there are metrics that are never incremented in
production code (e.g. outside of aggregation code and constructors).

Closes firecracker-microvm#5182

Co-authored-by: Milan Dhaduk <[email protected]>
Signed-off-by: Milan Dhaduk <[email protected]>
Co-authored-by: LDagnachew <[email protected]>
Signed-off-by: LDagnachew <[email protected]>
Signed-off-by: Patrick Roy <[email protected]>
@ShadowCurse ShadowCurse merged commit 31748a3 into firecracker-microvm:main Sep 24, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Awaiting review Indicates that a pull request is ready to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants