fix(test): do not override Firecracker binary #5441
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bchalios
added
the
Status: Awaiting review
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5441 +/- ##
=======================================
Coverage 82.67% 82.67%
=======================================
Files 263 263
Lines 27478 27478
=======================================
Hits 22718 22718
Misses 4760 4760
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bchalios
force-pushed
the
fix_redundant_seccomp_rules
branch
from
7f33aa8 to
a34e765
Compare
test_redundant_seccomp_rules builds the Firecracker binary using the nightly toolchain (we need this to be able to run its static analysis). This replaces the binary used by all subsequent tests and it causes them to fail since nightly might introduce a system call that is not allowed by our seccomp rules. In order to avoid such situations, build the binary used by the test in a different build directory. Signed-off-by: Babis Chalios <[email protected]>
bchalios
force-pushed
the
fix_redundant_seccomp_rules
branch
from
a34e765 to
c03b9ce
Compare
kalyazin
approved these changes
Sep 15, 2025
ShadowCurse
approved these changes
Sep 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Build the binary used by
test_redundant_seccomp_rulestest in an alternative build directory.Reason
test_redundant_seccomp_rulesbuilds the Firecracker binary using the nightly toolchain (we need this to be able to run its static analysis). This replaces the binary used by all subsequent tests and it causes them to fail since nightly might introduce a system call that is not allowed by our seccomp rules.License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkbuild --allto verify that the PR passesbuild checks on all supported architectures.
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.