Skip to content

fix(test): do not override Firecracker binary #5441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 15, 2025
Merged

fix(test): do not override Firecracker binary #5441

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions tests/integration_tests/build/test_seccomp_no_redundant_rules.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@
load_seccomp_rules,
)

# Make sure we don't override the Firecracker binary used from other tests
TMP_BUILD_DIR = "../redundant_seccomp_rules_build"


def test_redundant_seccomp_rules():
"""Test that fails if static analysis determines redundant seccomp rules"""
Expand All @@ -24,11 +27,11 @@ def test_redundant_seccomp_rules():
target = f"{arch}-unknown-linux-musl"

utils.check_output(
f'RUSTFLAGS="-C relocation-model=static -C link-args=-no-pie" cargo +{nightly_toolchain} -Zbuild-std=panic_abort,std build --release --target {target} -p firecracker'
f'CARGO_TARGET_DIR={TMP_BUILD_DIR} RUSTFLAGS="-C relocation-model=static -C link-args=-no-pie" cargo +{nightly_toolchain} -Zbuild-std=panic_abort,std build --release --target {target} -p firecracker'
)

found_syscalls = find_syscalls_in_binary(
Path(f"../build/cargo_target/{target}/release/firecracker")
Path(f"{TMP_BUILD_DIR}/{target}/release/firecracker")
)

seccomp_rules = load_seccomp_rules(Path(f"../resources/seccomp/{target}.json"))
Expand Down