Skip to content

fix(memory): avoid overflow in sum of memory region lengths #5482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 16, 2025
Merged

fix(memory): avoid overflow in sum of memory region lengths #5482

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/vmm/src/vstate/memory.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,7 +297,10 @@ pub fn snapshot_file(
track_dirty_pages: bool,
) -> Result<Vec<GuestRegionMmap>, MemoryError> {
let regions: Vec<_> = regions.collect();
let memory_size: u64 = regions.iter().map(|(_, size)| *size as u64).sum();
let memory_size = regions
.iter()
.try_fold(0u64, |acc, (_, size)| acc.checked_add(*size as u64))
.ok_or(MemoryError::OffsetTooLarge)?;
let file_size = file.metadata().map_err(MemoryError::FileMetadata)?.len();

// ensure we do not mmap beyond EOF. The kernel would allow that but a SIGBUS is triggered
Expand Down