Skip to content

Conversation

@kalyazin
Copy link
Contributor

@kalyazin kalyazin commented Jan 8, 2026

Changes

Temporarily ignore bincode advisory.

Reason

This is to fix pipelines while we're working on a migration to a substitution.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • I have read and understand CONTRIBUTING.md.
  • I have run tools/devtool checkbuild --all to verify that the PR passes
    build checks on all supported architectures.
  • I have run tools/devtool checkstyle to verify that the PR passes the
    automated style checks.
  • I have described what is done in these changes, why they are needed, and
    how they are solving the problem in a clear and encompassing way.
  • I have updated any relevant documentation (both in code and in the docs)
    in the PR.
  • I have mentioned all user-facing changes in CHANGELOG.md.
  • If a specific issue led to this PR, this PR closes the issue.
  • When making API changes, I have followed the
    Runbook for Firecracker API changes.
  • I have tested all new and changed functionalities in unit tests and/or
    integration tests.
  • I have linked an issue to every new TODO.

  • This functionality cannot be added in rust-vmm.

This is to fix pipelines while we're working on a migration to a
substitution.

Signed-off-by: Nikita Kalyazin <[email protected]>
@codecov
Copy link

codecov bot commented Jan 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.23%. Comparing base (bc37a09) to head (f425666).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5613   +/-   ##
=======================================
  Coverage   83.23%   83.23%           
=======================================
  Files         277      277           
  Lines       29262    29262           
=======================================
  Hits        24357    24357           
  Misses       4905     4905           
Flag Coverage Δ
5.10-m5n.metal 83.57% <ø> (-0.01%) ⬇️
5.10-m6a.metal 82.91% <ø> (-0.01%) ⬇️
5.10-m6g.metal 80.19% <ø> (+<0.01%) ⬆️
5.10-m6i.metal 83.57% <ø> (-0.01%) ⬇️
5.10-m7a.metal-48xl 82.90% <ø> (ø)
5.10-m7g.metal 80.19% <ø> (ø)
5.10-m7i.metal-24xl 83.54% <ø> (-0.01%) ⬇️
5.10-m7i.metal-48xl 83.55% <ø> (ø)
5.10-m8g.metal-24xl 80.18% <ø> (-0.01%) ⬇️
5.10-m8g.metal-48xl 80.18% <ø> (-0.01%) ⬇️
6.1-m5n.metal 83.60% <ø> (ø)
6.1-m6a.metal 82.94% <ø> (+<0.01%) ⬆️
6.1-m6g.metal 80.18% <ø> (ø)
6.1-m6i.metal 83.60% <ø> (+<0.01%) ⬆️
6.1-m7a.metal-48xl 82.93% <ø> (ø)
6.1-m7g.metal 80.18% <ø> (-0.01%) ⬇️
6.1-m7i.metal-24xl 83.61% <ø> (ø)
6.1-m7i.metal-48xl 83.61% <ø> (-0.01%) ⬇️
6.1-m8g.metal-24xl 80.18% <ø> (-0.01%) ⬇️
6.1-m8g.metal-48xl 80.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kalyazin kalyazin merged commit a61c603 into firecracker-microvm:main Jan 8, 2026
7 checks passed
@kalyazin kalyazin deleted the bincode branch January 8, 2026 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants