perf: Use vector methods for vector mutation in MoveEffect, SizeEffect, and ScaleEffect #3798
+39
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d vector2 methods
gnarhard
changed the title
Contributor
Author
|
Jeez, that broke a bunch of tests, I'm bailing on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, MoveEffect, ScaleEffect, and SizeEffect each create a bunch of unnecessary Vector2 objects in apply() which runs in the update loop. Migrating to using the vector methods to handle the mutation of those objects should reduce per-frame object churn and GC pressure.
I also added the ability to change the destination in MoveEffects to allow for more flexibility when pooling.
Checklist
docsand added dartdoc comments with///.examplesordocs.Breaking Change?
Related Issues