perf: Use vector methods for vector mutation in MoveEffect, SizeEffect, and ScaleEffect

packages/flame/lib/src/effects/move_by_effect.dart

@@ -1,6 +1,7 @@
 import 'package:flame/src/effects/controllers/effect_controller.dart';
 import 'package:flame/src/effects/move_effect.dart';
 import 'package:flame/src/effects/provider_interfaces.dart';
+import 'package:meta/meta.dart';
 import 'package:vector_math/vector_math.dart';
 
 /// A [MoveEffect] that moves its target by the specified offset vector.
@@ -28,11 +29,19 @@ class MoveByEffect extends MoveEffect {
        super(controller, target, onComplete: onComplete);
 
   final Vector2 _offset;
+  final Vector2 _scaledOffset = Vector2.zero();
 
   @override
   void apply(double progress) {
     final dProgress = progress - previousProgress;
-    target.position += _offset * dProgress;
+    _scaledOffset.setFrom(_offset);
+    _scaledOffset.scale(dProgress);
+    target.position.add(_scaledOffset);
+  }
+
+  @mustCallSuper
+  void updateOffset(Vector2 newOffset) {
+    _offset.setFrom(newOffset);
   }
 
   @override

packages/flame/lib/src/effects/move_to_effect.dart

@@ -27,29 +27,40 @@ class MoveToEffect extends MoveEffect {
     void Function()? onComplete,
     super.key,
   }) : _destination = destination.clone(),
-       _offset = Vector2.zero(),
        super(controller, target, onComplete: onComplete);
 
   final Vector2 _destination;
-  final Vector2 _offset;
+  final Vector2 _offset = Vector2.zero();
+  final Vector2 _scaledOffset = Vector2.zero();
 
   @override
   @mustCallSuper
   void onMount() {
     super.onMount();
-    _offset.setFrom(_destination - target.position);
+    _offset.setFrom(_destination);
+    _offset.sub(target.position);
   }
 
   @override
   @mustCallSuper
   void onStart() {
-    _offset.setFrom(_destination - target.position);
+    _offset.setFrom(_destination);
+    _offset.sub(target.position);
+  }
+
+  @mustCallSuper
+  void updateDestination(Vector2 newDestination) {
+    _destination.setFrom(newDestination);
+    _offset.setFrom(_destination);
+    _offset.sub(target.position);
   }
 
   @override
   void apply(double progress) {
     final dProgress = progress - previousProgress;
-    target.position += _offset * dProgress;
+    _scaledOffset.setFrom(_offset);
+    _scaledOffset.scale(dProgress);
+    target.position.add(_scaledOffset);
   }
 
   @override

packages/flame/lib/src/effects/scale_effect.dart

@@ -37,6 +37,7 @@ class ScaleEffect extends Effect with EffectTarget<ScaleProvider> {
 
   final Vector2 _scaleFactor;
   late Vector2 _scaleDelta;
+  final Vector2 _scaledScaleDelta = Vector2.zero();
 
   @override
   void onStart() {
@@ -49,7 +50,9 @@ class ScaleEffect extends Effect with EffectTarget<ScaleProvider> {
   @override
   void apply(double progress) {
     final dProgress = progress - previousProgress;
-    target.scale += _scaleDelta * dProgress;
+    _scaledScaleDelta.setFrom(_scaleDelta);
+    _scaledScaleDelta.scale(dProgress);
+    target.scale.add(_scaledScaleDelta);
   }
 }
 
@@ -71,6 +74,7 @@ class _ScaleToEffect extends ScaleEffect {
 
   @override
   void onStart() {
-    _scaleDelta = _targetScale - target.scale;
+    _scaleDelta = _targetScale;
+    _scaleDelta.sub(target.scale);
   }
 }

packages/flame/lib/src/effects/size_effect.dart

@@ -44,12 +44,15 @@ class SizeEffect extends Effect with EffectTarget<SizeProvider> {
     key: key,
   );
 
-  Vector2 _offset;
+  final Vector2 _offset;
+  final Vector2 _scaledOffset = Vector2.zero();
 
   @override
   void apply(double progress) {
     final dProgress = progress - previousProgress;
-    target.size += _offset * dProgress;
+    _scaledOffset.setFrom(_offset);
+    _scaledOffset.scale(dProgress);
+    target.size.add(_scaledOffset);
     target.size.clampScalar(0, double.infinity);
   }
 }
@@ -72,6 +75,7 @@ class _SizeToEffect extends SizeEffect {
 
   @override
   void onStart() {
-    _offset = _targetSize - target.size;
+    _offset.setFrom(_targetSize);
+    _offset.sub(target.size);
   }
 }