Skip to content

Conversation

@adityathebe
Copy link
Member

@adityathebe adityathebe commented Dec 8, 2025

Summary by CodeRabbit

  • Bug Fixes
    • Fixed rendering of certain view configurations to display content properly without redundant sections.

✏️ Tip: You can customize this high-level summary in your review settings.

@vercel
Copy link

vercel bot commented Dec 8, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
aws-preview Ready Ready Preview Dec 8, 2025 6:45am
flanksource-ui Ready Ready Preview Dec 8, 2025 6:45am

@coderabbitai
Copy link

coderabbitai bot commented Dec 8, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Adds logic to detect aggregator views—views with sections but no panels or columns—and conditionally skips rendering the primary ViewSection for these view types. Introduces an isAggregatorView computed property to control rendering behavior based on section and panel presence.

Changes

Cohort / File(s) Change Summary
View aggregation logic
src/pages/views/components/SingleView.tsx
Adds aggregator view detection via isAggregatorView computed property and guards primary ViewSection rendering to skip it for aggregator views while maintaining normal rendering for standard views

Possibly related PRs

  • feat: view sections #2739: Modifies section-rendering control flow in SingleView to support per-section ViewSection rendering, affecting similar aggregator logic.
  • feat(view): Collapsible section #2743: Changes primary section derivation and layout in SingleView, directly impacting the same ViewSection rendering path.

Suggested reviewers

  • moshloop
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/hide-aggregating-views

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 168a255 and ecb024c.

📒 Files selected for processing (1)
  • src/pages/views/components/SingleView.tsx (2 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@adityathebe adityathebe force-pushed the fix/hide-aggregating-views branch from fa58a70 to ecb024c Compare December 8, 2025 06:40
@adityathebe adityathebe requested a review from moshloop December 8, 2025 06:44
@adityathebe adityathebe enabled auto-merge (rebase) December 8, 2025 06:45
@adityathebe adityathebe merged commit beae0a4 into main Dec 8, 2025
12 checks passed
@adityathebe adityathebe deleted the fix/hide-aggregating-views branch December 8, 2025 06:45
@netlify
Copy link

netlify bot commented Dec 13, 2025

Deploy Preview for clerk-saas-ui failed. Why did it fail? →

Name Link
🔨 Latest commit ecb024c
🔍 Latest deploy log https://app.netlify.com/projects/clerk-saas-ui/deploys/693672e92a15b600081e6198

@netlify
Copy link

netlify bot commented Dec 14, 2025

Deploy Preview for flanksource-demo-stable failed. Why did it fail? →

Name Link
🔨 Latest commit ecb024c
🔍 Latest deploy log https://app.netlify.com/projects/flanksource-demo-stable/deploys/693672e902295b00086cb7da

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants