Skip to content

fix: hide primary view section if it only aggregates other views (via view sections) #2764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adityathebe merged 1 commit into from
Dec 8, 2025
Merged

fix: hide primary view section if it only aggregates other views (via view sections) #2764

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 17 additions & 7 deletions src/pages/views/components/SingleView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,13 @@ const SingleView: React.FC<SingleViewProps> = ({ id }) => {
}
};

// Check if this view only aggregates other views (has sections but no content of its own)
const isAggregatorView =
viewResult.sections &&
viewResult.sections.length > 0 &&
!viewResult.panels &&
!viewResult.columns;

return (
<ViewLayout
title={title || name}
Expand Down Expand Up @@ -196,13 +203,16 @@ const SingleView: React.FC<SingleViewProps> = ({ id }) => {
<hr className="my-4 border-gray-200" />
)}

<div className="mt-2">
<ViewSection
key={`${namespace || "default"}:${name}`}
section={primaryViewSection}
hideVariables
/>
</div>
{/* Only show the primary ViewSection if this view has its own content */}
{!isAggregatorView && (
<div className="mt-2">
<ViewSection
key={`${namespace || "default"}:${name}`}
section={primaryViewSection}
hideVariables
/>
</div>
)}

{viewResult?.sections && viewResult.sections.length > 0 && (
<>
Expand Down
Loading