Skip to content

Conversation

@ipaqsa
Copy link
Contributor

@ipaqsa ipaqsa commented Nov 24, 2025

Overview

It fixes nelm rendering for resources monitor

IT ALSO REMOVES USELESS CALLBACKS

What this PR does / why we need it

We need it to repair helm resources monitor, we do not parse correctly nelm rendered manifests, so resources monitors do not work.

root@paksashvili-master-0:~# kubectl get deploy -n d8-multitenancy-manager
No resources found in d8-multitenancy-manager namespace.
root@paksashvili-master-0:~# kubectl get deploy -n d8-multitenancy-manager -w
NAME                   READY   UP-TO-DATE   AVAILABLE   AGE
multitenancy-manager   0/1     0            0           0s
multitenancy-manager   0/1     0            0           0s
multitenancy-manager   0/1     0            0           0s
multitenancy-manager   0/1     1            0           0s
multitenancy-manager   1/1     1            1           1s

Signed-off-by: Stepan Paksashvili <[email protected]>
@ipaqsa ipaqsa requested a review from ldmonster November 24, 2025 12:55
@ipaqsa ipaqsa self-assigned this Nov 24, 2025
@ipaqsa ipaqsa added bug Something isn't working go Pull requests that update Go code release-note/bug Something isn't working labels Nov 24, 2025
@ipaqsa ipaqsa marked this pull request as ready for review November 24, 2025 15:02
@ldmonster ldmonster merged commit e5dd964 into main Nov 24, 2025
17 of 18 checks passed
@ldmonster ldmonster deleted the fix/helm-resource-monitor branch November 24, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working go Pull requests that update Go code release-note/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants