Skip to content

[fix] helm resources monitor #702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ldmonster merged 1 commit into from
Nov 24, 2025
Merged

[fix] helm resources monitor #702

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions pkg/addon-operator/operator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,18 +106,6 @@ func WithLogger(logger *log.Logger) Option {
}
}

func WithOnConvergeStart(callback func()) Option {
return func(operator *AddonOperator) {
operator.ConvergeState.SetOnConvergeStart(callback)
}
}

func WithOnConvergeFinish(callback func()) Option {
return func(operator *AddonOperator) {
operator.ConvergeState.SetOnConvergeFinish(callback)
}
}

func NewAddonOperator(ctx context.Context, metricsStorage, hookMetricStorage metricsstorage.Storage, opts ...Option) *AddonOperator {
cctx, cancel := context.WithCancel(ctx)

Expand Down
2 changes: 1 addition & 1 deletion pkg/helm/nelm/nelm.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -435,7 +435,7 @@ func (c *NelmClient) Render(releaseName, modulePath string, valuesPaths, setValu

var result strings.Builder
for _, resource := range chartRenderResult.Resources {
b, err := yaml.Marshal(resource)
b, err := yaml.Marshal(resource.Unstruct)
if err != nil {
return "", fmt.Errorf("marshal resource: %w", err)
}
Expand Down
Loading