fix: apply default healthcheck intervals for readycheck sidecars#397
fix: apply default healthcheck intervals for readycheck sidecars#397canercidam merged 1 commit intomainfrom
Conversation
When ReadyCheck fields (Interval, Timeout, etc.) are zero-valued (e.g. from YAML recipes), Docker interprets "0s" as "use defaults" which means a 30s polling interval. This caused services like ClickHouse to appear to take ~30s to start when they were actually ready in ~2s. Apply sensible defaults (1s interval, 10s timeout, 30 retries).
|
Claude finished @dvush's task in 57s —— View job PR Review: fix: apply default healthcheck intervals for readycheck sidecars
LGTM. The change is well-scoped and solves the right problem. YAML recipes create One minor observation, not blocking: The defaults are applied only in the sidecar code path inside |
When ReadyCheck fields (Interval, Timeout, etc.) are zero-valued (e.g. from YAML recipes), Docker interprets "0s" as "use defaults" which means a 30s polling interval. This caused services like ClickHouse to appear to take ~30s to start when they were actually ready in ~2s.
Apply sensible defaults (1s interval, 10s timeout, 30 retries).