Skip to content

fix: apply default healthcheck intervals for readycheck sidecars #397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
canercidam merged 1 commit into from
Mar 9, 2026
Merged

fix: apply default healthcheck intervals for readycheck sidecars #397

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions playground/manifest.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,6 +279,20 @@ func (s *Manifest) Validate(out *output) error {

readyCheck := *ss.ReadyCheck
ss.ReadyCheck = nil

// Apply sensible defaults so Docker doesn't fall back to 30s interval
if readyCheck.Interval == 0 {
readyCheck.Interval = 1 * time.Second
}
if readyCheck.Timeout == 0 {
readyCheck.Timeout = 10 * time.Second
}
if readyCheck.Retries == 0 {
readyCheck.Retries = 30
}
if readyCheck.StartPeriod == 0 {
readyCheck.StartPeriod = 1 * time.Second
}
ss.WithLabel(healthCheckSidecarLabel, sidecarName)

// the url supplied by the service will bind to localhost, we have to change it
Expand Down