fix(builder-playground): config-playground.toml tweaks for playground DX#364
Merged
fix(builder-playground): config-playground.toml tweaks for playground DX#364
Conversation
Benchmark results for
|
| Date (UTC) | 2025-01-20T23:05:24+00:00 |
| Commit | 76fe5eed81774b7e7d49ef3526cbe44aaa52f1cd |
| Base SHA | cf49d292aa559f9405bf37963f206b7aaa809a6c |
Significant changes
| Benchmark | Mean | Status |
|---|---|---|
| ptr_trie_insert_only_3000 | -2.61% | Performance has improved. |
| hashing_3000_elements_with_cache | 3.04% | Performance has degraded. |
| cloning_3000_branch_node_size_elements | 3.56% | Performance has degraded. |
| gather_nodes_clone | -11.78% | Performance has improved. |
| gather_nodes_empty_account | -24.12% | Performance has improved. |
ZanCorDX
approved these changes
Jan 20, 2025
ferranbt
approved these changes
Jan 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
While getting flashbots/builder-playground#37 working I ran into a couple DX gotchas with the current
config-playground.tomlfile.💡 Motivation and Context
parallelalgoirthm was pegging all my CPUs at 100%. Also figured just runningmgp-orderingis enough.✅ I have completed the following steps:
make lintmake test