Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ci/docker-tags.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
flashinfer/flashinfer-ci-cu126: 20260203-9b5901e
flashinfer/flashinfer-ci-cu128: 20260203-9b5901e
flashinfer/flashinfer-ci-cu129: 20260203-9b5901e
flashinfer/flashinfer-ci-cu130: 20260203-9b5901e
flashinfer/flashinfer-ci-cu126: 20260209-a2d3b39
flashinfer/flashinfer-ci-cu128: 20260209-a2d3b39
flashinfer/flashinfer-ci-cu129: 20260209-a2d3b39
flashinfer/flashinfer-ci-cu130: 20260209-a2d3b39
Comment on lines +1 to +4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve maintainability and reduce redundancy, consider refactoring this file to define the Docker tag once and reuse it. Since the tag is the same for all images, you can use a YAML anchor if this file is consumed by a standard YAML parser. This would make it easier to update the tag in the future and prevent potential inconsistencies.

For example:

tag: &tag 20260209-a2d3b39
flashinfer/flashinfer-ci-cu126: *tag
flashinfer/flashinfer-ci-cu128: *tag
flashinfer/flashinfer-ci-cu129: *tag
flashinfer/flashinfer-ci-cu130: *tag

If a custom script parses this file, you might consider refactoring the script and this file to source the tag from a single variable. This would make the process of updating tags more robust.

Loading