Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions src/builder-module.c
Original file line number Diff line number Diff line change
Expand Up @@ -1780,6 +1780,22 @@ builder_module_build_helper (BuilderModule *self,
{
/* Meson's setup command is now meson setup */
g_ptr_array_add (configure_args_arr, g_strdup ("setup"));
/*
* By default network access inside the build sandbox is disabled,
* however meson defaults into trying to initialize fallbacks and attempt to
* download them, returning a potentially misleading error message.
*
* Setting wrap-mode to nodownload will instruct meson to not try to use the
* network to fetch any resources and only the pre-existing checkouts will be
* taken into account. This matches both the default network permission
* and the design of flatpak-builder for bundling and staging all the sources
* ahead of time.
*
* Side effect is that it makes it slightly harder for projects to use the
* network access at build time, is they also have to edit their meson setup
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* network access at build time, is they also have to edit their meson setup
* network access at build time, as they also have to edit their meson setup

* arguments to change the wrap-mode.
*/
g_ptr_array_add (configure_args_arr, g_strdup ("--wrap-mode=nodownload"));
}

if (cmake || cmake_ninja)
Expand Down