builder-module: Change the default wrap-mode policy of meson #643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alatiera
force-pushed
the
alatiera/meson-nodownload
branch
3 times, most recently
from
d386805 to
aa3f27f
Compare
By default network access inside the build sandbox is disabled, however meson defaults into trying to initialize fallbacks and attempt to download them, returning a potentially misleading error message. Setting wrap-mode to nodownload will instruct meson to not try to use the network to fetch any resources and only the pre-existing checkouts will be taken into account. This matches both the default network permission and the design of flatpak-builder for bundling and staging all the sources ahead of time. Side effect is that it makes it slightly harder for projects to use the network access at build time, is they also have to edit their meson setup arguments to change the wrap-mode.
alatiera
force-pushed
the
alatiera/meson-nodownload
branch
from
aa3f27f to
59554ec
Compare
Contributor
|
Makes sense to me, thanks |
alatiera
commented
Jul 5, 2025
| * ahead of time. | ||
| * | ||
| * Side effect is that it makes it slightly harder for projects to use the | ||
| * network access at build time, is they also have to edit their meson setup |
Contributor
Author
There was a problem hiding this comment.
Suggested change
| * network access at build time, is they also have to edit their meson setup | |
| * network access at build time, as they also have to edit their meson setup |
Contributor
|
as is it will break ci uses cases of flatpak-builder where often the developer workflow is to build with network access. so probably this should not be set when the build sandbox has network access. |
bbhtt
added a commit
that referenced
this pull request
Oct 18, 2025
bbhtt
added a commit
that referenced
this pull request
Oct 18, 2025
bbhtt
added a commit
that referenced
this pull request
Oct 19, 2025
bbhtt
added a commit
that referenced
this pull request
Oct 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default network access inside the build sandbox is disabled, however meson defaults into trying to initialize fallbacks and attempt to download them, returning a potentially misleading error message.
Setting wrap-mode to nodownload will instruct meson to not try to use the network to fetch any resources and only the pre-existing checkouts will be taken into account. This matches both the default network permission and the design of flatpak-builder for bundling and staging all the sources ahead of time.
Side effect is that it makes it slightly harder for projects to use the network access at build time, is they also have to edit their meson setup arguments to change the wrap-mode.