feat(): Convert zone not found errors to warnings in entity updates #1708
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8c7b03eb84
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| _update_entity_full_name(self, _VolumeEntityBase, volume_mesh_meta_data) | ||
| warnings = [] | ||
| warnings.extend(_update_entity_full_name(self, _SurfaceEntityBase, volume_mesh_meta_data)) | ||
| warnings.extend(_update_entity_full_name(self, _VolumeEntityBase, volume_mesh_meta_data)) |
There was a problem hiding this comment.
Volume entities silently fail without generating warnings
Medium Severity
The PR converts surface entity "zone not found" errors to warnings, but _VolumeEntityBase._update_entity_info_with_metadata still returns None and was not updated to return warnings. When _update_entity_full_name is called with _VolumeEntityBase, it attempts to collect warnings from _update_entity_info_with_metadata, but the method always returns None. This means volume zones that can't be found in metadata will silently fail to update without generating any warning, defeating the PR's purpose of surfacing these issues as warnings.
So the subsequent process can still continue
Note
Shifts entity metadata update failures from hard errors to collected warnings, allowing processing to continue.
_get_boundary_full_namenow returns(full_name, warning)instead of raisingFlow360BoundaryMissingError; import removed_SurfaceEntityBase._update_entity_info_with_metadatareturnsOptional[str]warning and only setsprivate_attribute_full_namewhen found_update_entity_full_name(model, target_entity_type, volume_mesh_meta_data)now returnsList[str]of warnings, aggregating from nested entitiesSimulationParams._update_param_with_actual_volume_mesh_metareturnslist[str]of warnings (aggregates surface and volume warnings) while still updating zone boundaries via_update_zone_boundaries_with_metadataWritten by Cursor Bugbot for commit 5904d94. This will update automatically on new commits. Configure here.