-
Notifications
You must be signed in to change notification settings - Fork 9
feat(): Convert zone not found errors to warnings in entity updates #1708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -633,20 +633,23 @@ def used_entity_registry(self) -> EntityRegistry: | |
| registry = self._update_entity_private_attrs(registry) | ||
| return registry | ||
|
|
||
| def _update_param_with_actual_volume_mesh_meta(self, volume_mesh_meta_data: dict): | ||
| def _update_param_with_actual_volume_mesh_meta(self, volume_mesh_meta_data: dict) -> list[str]: | ||
| """ | ||
| Update the zone info from the actual volume mesh before solver execution. | ||
| Will be executed in the casePipeline as part of preprocessing. | ||
| Some thoughts: | ||
| Do we also need to update the params when the **surface meshing** is done? | ||
|
|
||
| Returns a list of warning messages for entities that could not be found in metadata. | ||
| """ | ||
| # pylint:disable=no-member | ||
| used_entity_registry = self.used_entity_registry | ||
| # Below includes the Ghost entities. | ||
| _update_entity_full_name(self, _SurfaceEntityBase, volume_mesh_meta_data) | ||
| _update_entity_full_name(self, _VolumeEntityBase, volume_mesh_meta_data) | ||
| warnings = [] | ||
| warnings.extend(_update_entity_full_name(self, _SurfaceEntityBase, volume_mesh_meta_data)) | ||
| warnings.extend(_update_entity_full_name(self, _VolumeEntityBase, volume_mesh_meta_data)) | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Volume entities silently fail without generating warningsMedium Severity The PR converts surface entity "zone not found" errors to warnings, but Additional Locations (1) |
||
| _update_zone_boundaries_with_metadata(used_entity_registry, volume_mesh_meta_data) | ||
| return self | ||
| return warnings | ||
|
|
||
| def is_steady(self): | ||
| """ | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.