Skip to content

Conversation

@chenzhuofu
Copy link
Collaborator

@chenzhuofu chenzhuofu commented Jan 16, 2025

Description of changes:

  • fix kernels tests compiling bugs
  • make kernels tests (nixGL) compatible with ctest
  • enable GPU CI

Issues closed by this PR:

Before merging:

  • Did you update the flexflow-third-party repo, if modifying any of the Cmake files, the build configs, or the submodules?

This change is Reviewable

@chenzhuofu chenzhuofu changed the title Repo refactor fix kernels tests GPU CI & kernels tests fix Jan 16, 2025
@chenzhuofu chenzhuofu requested a review from lockshaw January 16, 2025 08:25
@codecov
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.47%. Comparing base (8f64a0f) to head (373baf8).
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1578       +/-   ##
===========================================
- Coverage   78.70%   60.47%   -18.24%     
===========================================
  Files         875      606      -269     
  Lines       29406    14723    -14683     
  Branches      778        0      -778     
===========================================
- Hits        23144     8903    -14241     
+ Misses       6262     5820      -442     
Flag Coverage Δ
unittests 60.47% <ø> (-18.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 322 files with indirect coverage changes

@lockshaw lockshaw enabled auto-merge (squash) January 17, 2025 03:42
@lockshaw lockshaw disabled auto-merge January 17, 2025 03:42
@lockshaw lockshaw merged commit 0a13572 into master Jan 17, 2025
15 of 18 checks passed
@lockshaw lockshaw deleted the repo-refactor-fix-kernels-tests branch January 17, 2025 04:12
@lockshaw lockshaw mentioned this pull request Jan 18, 2025
1 task
@victorli2002 victorli2002 mentioned this pull request Mar 12, 2025
@victorli2002 victorli2002 mentioned this pull request Apr 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build kernels-tests in non-GPU CI CUDA testing support in proj CUDA GPU CI for repo-refactor

3 participants