feat: add additional ts signatures and react-based types to detect #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahnopologetic
changed the title
Contributor
Author
|
Also, noticed CI is not calling new test code. I think it is because of cache. |
Contributor
Author
|
@skarim lmk what you think! |
Contributor
|
@ahnopologetic thanks for contributing! need to do a deeper read, but looks great at first glance! curious, did the existing version not work with react for you? i did some spot tests on react codebases (although not in the test suite) and did see events get extracted. is there a particular format you are looking to parse? |
skarim
added
enhancement
Contributor
Author
|
@skarim Hi. Yes, I saw some of them works, but it does not extract some simple usecases like this: mixpanelAnalytics.trackUserScenario('sign_up: completed', {And the mixpanelAnalytics is declared like this export class MixpanelAnalytics {
app: MixpanelModule;
debug: boolean;
constructor(app: MixpanelModule, debug: boolean = false) {
this.app = app;
this.debug = debug;
}
trackUserScenario(eventName: string, properties: Record<string, any> = {}) {
if (properties?.is_user_scenario === false) {
console.warn(
'MixpanelAnalytics.trackUserScenario(): is_user_scenario is false, use track instead',
);
}
this.app.track(eventName, {
...properties,
is_user_scenario: true,
});
}
...I tried to pull them up using customFunction option, but it turns out customFunction only checks if it is identifier (typescript AST), not other usecases like class property/method, and so forth. Thus, I added this part in isCustomFunction function: const canBeCustomFunction = ts.isIdentifier(node.expression) ||
ts.isPropertyAccessExpression(node.expression) ||
ts.isCallExpression(node.expression) || // For chained calls like getTracker().track()
ts.isElementAccessExpression(node.expression) || // For array/object access like trackers['analytics'].track()
(ts.isPropertyAccessExpression(node.expression?.expression) && ts.isThisExpression(node.expression.expression.expression)); // For class methods like this.analytics.track()I think this issue is specific to React usecases because they are usually wrapped by custom arrow functions, useCallbacks, and so on. Hope it helps you have a better understanding for this PR. |
skarim
requested changes
Jun 4, 2025
Contributor
skarim
left a comment
skarim
left a comment
There was a problem hiding this comment.
@ahnopologetic left some comments for a few areas that could be improved. open to your thoughts either way. lemme know when you have a chance to review/update and i'll get this into the next release!
Contributor
Author
|
@skarim Just to make sure, resolved your all RCs and passed the tests locally. 👍 |
skarim
approved these changes
Jun 5, 2025
Contributor
skarim
left a comment
skarim
left a comment
There was a problem hiding this comment.
lgtm ✅
thanks @ahnopologetic!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a feature that parse react-based codebase as well.
mixpanelAnalytics.trackwhich is a property of a custom class).