Skip to content

Conversation

@Watson1978
Copy link
Contributor

The exception message will be output at the following location and it is enough.

Related to #6

Signed-off-by: Shizuo Fujita <[email protected]>
@Watson1978 Watson1978 requested review from daipom and kenhys August 28, 2025 04:48
@daipom
Copy link
Contributor

daipom commented Aug 28, 2025

Thanks!
Shouldn't this removal be in ensure block?

@Watson1978
Copy link
Contributor Author

Watson1978 commented Aug 28, 2025

Hmm, since it's a temporary directory, we probably don't need to delete it for sure.
If you're concerned, an ensure block would be better.

Signed-off-by: Shizuo Fujita <[email protected]>
@daipom
Copy link
Contributor

daipom commented Aug 28, 2025

Thanks!

Hmm, since it's a temporary directory, we probably don't need to delete it for sure. If you're concerned, an ensure block would be better.

In environments where machines are rarely rebooted and run for long periods, I’m concerned about the possibility of disk space being exhausted.
Since this error occurs before the file is created, I believe it should be fine, but I thought it would be safer to design it robustly just in case.

Copy link
Contributor

@daipom daipom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@daipom daipom merged commit a8a8c07 into fluent-plugins-nursery:main Aug 28, 2025
6 checks passed
@Watson1978 Watson1978 deleted the log-level branch August 28, 2025 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants