Skip to content

Remove unnecessary error log #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 28, 2025
Merged

Remove unnecessary error log #10

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d32d57b
Remove unnecessary error log
Watson1978 Aug 28, 2025
448d220
Add ensure block for safety
Watson1978 Aug 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 10 additions & 13 deletions lib/fluent/plugin/fluent_package_update_checker.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ def tags_cached?
end

def cached_tags_path
ENV["FLUENT_PACKAGE_TAGS_PATH"] ?
ENV["FLUENT_PACKAGE_TAGS_PATH"] ?
ENV["FLUENT_PACKAGE_TAGS_PATH"] : "#{@tmp_dir}/fluent-package-tags.json"
end

Expand All @@ -51,20 +51,16 @@ def release_tags_url
end

def fetch_tags
begin
if tags_cached?
yield JSON.parse(File.open(cached_tags_path).read)
else
URI.open(release_tags_url) do |resource|
File.open(cached_tags_path, "w+") do |f|
json = resource.read
f.write(json)
yield JSON.parse(json)
end
if tags_cached?
yield JSON.parse(File.open(cached_tags_path).read)
else
URI.open(release_tags_url) do |resource|
File.open(cached_tags_path, "w+") do |f|
json = resource.read
f.write(json)
yield JSON.parse(json)
end
end
rescue => e
@logger.error "Failed to fetch tags", error: e
end
end

Expand Down Expand Up @@ -176,6 +172,7 @@ def check_update_versions
end
end
end
ensure
FileUtils.rm_rf(@tmp_dir)
end

Expand Down
Loading