Backport: Add fluent-release package for yum/dnf update (#845) #855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Need to rebase with #856 |
kenhys
force-pushed
the
fluent-release-latest
branch
from
0190d09 to
a284102
Compare
Contributor
Author
|
Rebased with #856 |
kenhys
force-pushed
the
fluent-release-latest
branch
3 times, most recently
from
5931397 to
7cb73cb
Compare
Contributor
|
The following backport will resolve test failures for AmazonLinux 2. |
kenhys
force-pushed
the
fluent-release-latest
branch
2 times, most recently
from
6523874 to
6cc89c2
Compare
daipom
reviewed
Jul 9, 2025
Contributor
daipom
left a comment
daipom
left a comment
There was a problem hiding this comment.
Thanks! Basicially, looks good to me!
fluent-package-lts-v5 section in fluent-package-lts.repo was enabled by default
Could you tell me why we enable lts-v5 instead of lts-v6?
(In #845, we enable v6 by default, so why is there a difference?)
Contributor
Author
This is for v5 LTS branch. |
rpm: add fluent-release package for yum/dnf update In the previous versions, .repo file was assumed to be created via fluent-package installation script. For migration from packages.treasuredata.com to fluentd.cdn.cncf.io in the future, it might be better to setup proper fluent-release package for it. Changed in backport * baseurl was changed to LTS * fluent-package.repo => fluent-package-lts.repo * changed section name (fluent-package-lts => fluent-package-lts-v5) in fluent-package-lts.repo * fluent-package-lts-v5 section in fluent-package-lts.repo was enabled by default Signed-off-by: Kentaro Hayashi <[email protected]> Co-authored-by: Daijiro Fukuda <[email protected]> Signed-off-by: Kentaro Hayashi <[email protected]>
kenhys
force-pushed
the
fluent-release-latest
branch
from
6cc89c2 to
4455281
Compare
Contributor
Ah, I see! Thanks! |
daipom
added a commit
to Watson1978/fluent-package-builder
that referenced
this pull request
Oct 3, 2025
This was added wrongly at fluent#855. Signed-off-by: Daijiro Fukuda <[email protected]>
daipom
added a commit
that referenced
this pull request
Oct 3, 2025
This PR will fix backport error in #917 and #855. When I solve the conflict, I introduced the error. Therefore, the `yum` workflow does not works properly. --------- Signed-off-by: Shizuo Fujita <[email protected]> Signed-off-by: Daijiro Fukuda <[email protected]> Co-authored-by: Daijiro Fukuda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rpm: add fluent-release package for yum/dnf update
In the previous versions, .repo file was assumed to be created via fluent-package installation script.
For migration from packages.treasuredata.com to fluentd.cdn.cncf.io in the future, it might be better to setup proper fluent-release package for it.
Changed in backport