Skip to content

[a11y] If there is no action, return immediately#76

Merged
JSUYA merged 3 commits intoflutter-tizen:masterfrom
JSUYA:a11y_do_action_name
Feb 18, 2025
Merged

[a11y] If there is no action, return immediately#76
JSUYA merged 3 commits intoflutter-tizen:masterfrom
JSUYA:a11y_do_action_name

Conversation

@JSUYA
Copy link
Member

@JSUYA JSUYA commented Dec 4, 2024

The index of DoAction is the number of the action that can be called.
If there is no action that can be called in atk, the index is passed as -1.
Currently, our AXPlatformNode only supports default actions, so we need to distinguish between -1 and numbers greater than 0.
In Tizen, the DoActionName function in atk causes this problem.
Since at-spi2-atk in tizen is not under our management scope, we temporarily return immediately when it is -1 to prevent unnecessary error messages.

error message

[E] ** (Runner.dll:10005): CRITICAL **: 20:27:38.451: gboolean ui::(anonymous namespace)::atk_action::DoAction(AtkAction *, gint): assertion '!index' failed
[E] [0]: /usr/lib/libglog-runtime-env.so+0x78a (g_log_default_handler+0xb9) [0xb618578a]
[E] [1]: /lib/libglib-2.0.so.0+0x5053e (g_logv+0x149) [0xb5a6053e]
[E] [2]: /lib/libglib-2.0.so.0+0x50686 (g_log+0x25) [0xb5a60686]
[3]: /lib/libglib-2.0.so.0+0x50832 (g_return_if_fail_warning+0x11) [0xb5a60832]

The index of DoAction is the number of the action that can be called.
If there is no action that can be called in atk, the index is passed as -1.
Currently, our AXPlatformNode only supports default actions,
so we need to distinguish between -1 and numbers greater than 0.
In Tizen, the DoActionName function in atk causes this problem.
Since at-spi2-atk in tizen is not under our management scope,
we temporarily return immediately when it is -1 to prevent unnecessary error messages.
@JSUYA
Copy link
Member Author

JSUYA commented Dec 4, 2024

#8

@JSUYA JSUYA changed the title [a11y] If there is no action, return immediately. [a11y] If there is no action, return immediately Dec 4, 2024
@JSUYA JSUYA merged commit 183a0d6 into flutter-tizen:master Feb 18, 2025
9 checks passed
@JSUYA JSUYA deleted the a11y_do_action_name branch March 6, 2026 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants