Skip to content

[a11y] If there is no action, return immediately #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JSUYA merged 3 commits into from
Feb 18, 2025
Merged

[a11y] If there is no action, return immediately #76

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
60d0a34
[a11y] If there is no action, return immediately.
JSUYA Dec 4, 2024
1c5e097
Merge branch 'master' into a11y_do_action_name
swift-kim Feb 14, 2025
0b087df
Merge branch 'master' into a11y_do_action_name
JSUYA Feb 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion flutter/third_party/accessibility/ax/platform/ax_platform_node_auralinux.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -596,7 +596,15 @@ namespace atk_action {

gboolean DoAction(AtkAction* atk_action, gint index) {
g_return_val_if_fail(ATK_IS_ACTION(atk_action), FALSE);
g_return_val_if_fail(!index, FALSE);
// TODO(JSUYA): The index of DoAction is the number of the action that can be
// called. If there is no action that can be called in atk, the index is
// passed as -1. Currently, our AXPlatformNode only supports default actions,
// so we need to distinguish between -1 and numbers greater than 0. In Tizen,
// the DoActionName function in atk causes this problem. Since at-spi2-atk in
// tizen is not under our management scope, we temporarily return immediately
// when it is -1 to prevent unnecessary error messages.
if (index < 0)
return FALSE;

AtkObject* atk_object = ATK_OBJECT(atk_action);
AXPlatformNodeAuraLinux* obj =
Expand Down
Loading