Skip to content

Conversation

@pq
Copy link
Collaborator

@pq pq commented Nov 21, 2025

Adds test and problem report uploading to the dart-analysis-server-tests workflow:

image

Sample Reports

Tests

image image

Problems

image
  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

@gemini-code-assist
Copy link

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@pq pq changed the title [tests] upload test report artifacts [tests] add test and problem report uploading to the server test workflow Nov 21, 2025
@pq pq requested review from cj-radcliff and jwren November 21, 2025 04:40
@pq
Copy link
Collaborator Author

pq commented Nov 21, 2025

Hilariously, this last run has no failures, but you can check out the problems report in the uploaded zip here:

https://github.com/flutter/dart-intellij-third-party/actions/runs/19559937926/artifacts/4636302178

Copy link
Collaborator

@cj-radcliff cj-radcliff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pq pq merged commit 81f84b4 into main Nov 21, 2025
9 checks passed
@pq pq deleted the pq-test-report-upload branch November 21, 2025 18:55
working-directory: third_party

- name: Upload build artifacts
uses: actions/upload-artifact@v4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this works, this is great! What does the CLI output look like, i.e. is it discoverable when it is written to these locations? Also, why not add this to to the Jobs?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been watching runs and it seems to work as intended! 🎉

(For example, this recent run: job/56077860294 generated artifacts here.)

What does the CLI output look like, i.e. is it discoverable when it is written to these locations?

If you squint at the picture above you can see a link is printed in the results. Here it is again:

image

Also, why not add this to to the Jobs?

You mean add a separate job? What would be the benefit?

(FWIW I did try actually try that initially but hit some snags and couldn't get the upload-artifact action to find the artifacts. I think I understand why after sleeping on it. If there's a good reason to get that working I can take another crack. Just let me know!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants