-
Notifications
You must be signed in to change notification settings - Fork 3
[tests] add test and problem report uploading to the server test workflow #94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
|
Hilariously, this last run has no failures, but you can check out the problems report in the uploaded zip here: https://github.com/flutter/dart-intellij-third-party/actions/runs/19559937926/artifacts/4636302178 |
cj-radcliff
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| working-directory: third_party | ||
|
|
||
| - name: Upload build artifacts | ||
| uses: actions/upload-artifact@v4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this works, this is great! What does the CLI output look like, i.e. is it discoverable when it is written to these locations? Also, why not add this to to the Jobs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been watching runs and it seems to work as intended! 🎉
(For example, this recent run: job/56077860294 generated artifacts here.)
What does the CLI output look like, i.e. is it discoverable when it is written to these locations?
If you squint at the picture above you can see a link is printed in the results. Here it is again:
Also, why not add this to to the Jobs?
You mean add a separate job? What would be the benefit?
(FWIW I did try actually try that initially but hit some snags and couldn't get the upload-artifact action to find the artifacts. I think I understand why after sleeping on it. If there's a good reason to get that working I can take another crack. Just let me know!)
Adds test and problem report uploading to the
dart-analysis-server-testsworkflow:Sample Reports
Tests
Problems
Contribution guidelines:
dart format.